search

tladesignz / IPtProxy

Obfs4proxy and Snowflake Pluggable Transports for iOS
MIT License
45 stars 11 forks source link

Update lyrebird patch to properly show version string #57

Closed syphyr closed 3 months ago

syphyr commented 3 months ago

Fix displaying version string format in lyrebird. Lyrebird currently uses the git tag to form it's version string, and getVersion() displays the version string as lyrebird-%s in the same format as the git tag.

This basically reverts 72bd552f248fc955f744a50eb3269c9bb99b5735 "Take the version from git" in lyrebird's sources.

tladesignz commented 3 months ago

Oh, my. I'm surprised that this is so important to you.

TBH, I'm pretty pissed at what upstream did with the version. The changes mean, that I now have to take care to modify the patch file every time the version changes. Or add extra scripting to replicate the behaviour. Highly annoying.

That's probably the reason why I didn't look closely enough to what LyrebirdVersion should actually contain. You're right, it's the complete release tag.

However, my goal is to keep the patch file as small as possible. Hence, I despise your solution with the reintroduction of the getVersion method. That's 3 more lines and a fair amount of compute cycles for no difference.

Hence, I will decline your pull request. But rest assured, I'll fix the version string.

However, I won't put out another release just for this, as long as you're not coming up with a totally convining story, that you absolutely need that.