search

tlamadon / mpeccable

R package for constrained optimization of functional equation problems
5 stars 2 forks source link

coloring in FDiff #3

Open floswald opened 11 years ago

floswald commented 11 years ago

There is a problem in coloring when we have two FDiffs. see the last few lines of the "-" method for 2 FDiffs:

    # @FIXME this should be done everywhere
if (e1@coloring){
    e1@F = e1@F - e2@F
    e1@J = Jac1 | Jac2
} else {
    e1@F = e1@F - e2@F
    e1@J = Jac1 - Jac2
}
    return( applyColoring(e1) )

we don't want to have Jac1 - Jac2 in the coloring case, as that gives zero.