search

tlambert03 / PSFmodels

Python bindings for scalar and vectorial models of the 3D microscope point spread function.
GNU General Public License v3.0
44 stars 10 forks source link

not imported 'tot_psf' in psfmodels.__init__ #6

Closed ZhenhongDu closed 1 year ago

ZhenhongDu commented 2 years ago

Description

Recently, I installed PSFmodels on a new computer, and I found that the function 'tot_psf' were not imported in the psfmodels.initfunction, so when I used 'psf.tot_psf function', there was a mistake. I added it by myself. Did you forget it?

not imported in psfmodels.init

ZhenhongDu commented 2 years ago

By the way, I want to ask that the NA value used in ex_lens = {**air_lens, 'NA': 0.01} is the illumination objective NA in tot_psf mode? In general, the illumination objective NA of our system does not fill the whole back focal plane. Should I use the reduced NA?

tlambert03 commented 2 years ago

sorry about that, I removed it from the top level since I'm not sure how robust it is. I can add it back (but definitely use with some degree of caution and double check the source). You can still import it at 

from psfmodels._core import tot_psf

In general, the illumination objective NA of our system does not fill the whole back focal plane. Should I use the reduced NA?

yep, any NA entered into a field here should be assumed to be the "effective" NA. If you use an iris or otherwise don't fill the BFP, your effective NA is lower than the nominal NA on the objective.

ZhenhongDu commented 2 years ago

Ok, thank you for your reply！