search

tlambert03 / microvis

Other
2 stars 2 forks source link

remove _vis_set_width, _vis_set_height #28

Closed tlambert03 closed 1 year ago

tlambert03 commented 1 year ago

the CanvasAdaptorProtocol currently has all three of:

    @abstractmethod
    def _vis_set_width(self, arg: int) -> None: ...
    @abstractmethod
    def _vis_set_height(self, arg: int) -> None: ...
    @abstractmethod
    def _vis_set_size(self, arg: tuple[int, int]) -> None: ...

I think i did this cause pygfx only had a size setter and vispy had the other? can't remember. but we only need _vis_set_size and should remove the other two (setting just width, e.g. can just provide the current height to _vis_setsize)