search

tlambert03 / napari-omero

Browse your OMERO database from within napari.
GNU General Public License v2.0
33 stars 10 forks source link

windows ci fix #12

Closed tlambert03 closed 3 years ago

tlambert03 commented 4 years ago

trying to fix windows tests on github actions

joshmoore commented 4 years ago

Perhaps try installing pywin32? From omero-py's tox.ini:

    pywin32; platform_system=="Windows"

May need to get that pulled up into setup.py.

cc: @will-moore

codecov-commenter commented 4 years ago

Codecov Report

Merging #12 into master will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #12   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          11      12    +1     
  Lines         722     771   +49     
======================================
- Misses        722     771   +49
Impacted Files Coverage Δ
src/napari_omero/plugins/masks.py 0.00% <0.00%> (ø)
src/napari_omero/plugins/omero.py 0.00% <0.00%> (ø)
src/napari_omero/utils.py 0.00% <0.00%> (ø)
src/napari_omero/widgets/main.py 0.00% <0.00%> (ø)
src/napari_omero/widgets/gateway.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0acd635...b4e42ad. Read the comment docs.

joshmoore commented 3 years ago

Oops. Looks like this got orphaned. Good to go?

tlambert03 commented 3 years ago

sure, it only tests on 3.8, but better than nothing

joshmoore commented 3 years ago

:+1: Merging and we can see where we want to go from here.

joshmoore commented 3 years ago

Failed on master unfortunately:

 ERROR tests/test_utils.py - OSError: [WinError 87] The parameter is incorrect