search

tlambert03 / nd2

Full-featured nd2 (Nikon NIS Elements) file reader for python. Outputs to numpy, dask, and xarray. Exhaustive metadata extraction
https://tlambert03.github.io/nd2
BSD 3-Clause "New" or "Revised" License
53 stars 15 forks source link

fix: Make 'periodDiff' optional in TimeLoopParams construction #131

Closed SeanLeRoy closed 1 year ago

SeanLeRoy commented 1 year ago

See discussion here.

This is intended to allow periodDiff be an optional parameter to TimeLoopParams

tlambert03 commented 1 year ago

works for me if it works for you! I can follow up in another PR with a more general catch-all fix for missing params

tlambert03 commented 1 year ago

@SeanLeRoy, you have it marked as draft, so let me know if you want to do more. Otherwise , lgtm

SeanLeRoy commented 1 year ago

Ah it was just a draft until I got your approval during our discussion, hopefully you saw the 2 failing checks. I am assuming so and that they are irrelevant (it seems so) and will merge this end of day unless told otherwise!

tlambert03 commented 1 year ago

Yeah the fails are unrelated and fixed in another PR in the meantime

SeanLeRoy commented 1 year ago

@tlambert03 I don't have write access to your repo/main branch so I can't merge this. Feel free to whenever/if you see fit

tlambert03 commented 1 year ago

Yep different org :) thanks!