tlambert03 / nd2

Full-featured nd2 (Nikon NIS Elements) file reader for python. Outputs to numpy, dask, and xarray. Exhaustive metadata extraction
https://tlambert03.github.io/nd2
BSD 3-Clause "New" or "Revised" License
53 stars 15 forks source link

feat: Remove sdk, use all python #135

Closed tlambert03 closed 1 year ago

tlambert03 commented 1 year ago

This re-implements the complete sdk in python, with many thanks to the great folks at LIM for all their help.

cleaned up version of #122 closes #122

codecov[bot] commented 1 year ago

Codecov Report

Merging #135 (77d87ed) into main (2f1f137) will increase coverage by 4.83%. The diff coverage is 91.55%.

@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
+ Coverage   86.55%   91.38%   +4.83%     
==========================================
  Files          10       13       +3     
  Lines        1145     1962     +817     
==========================================
+ Hits          991     1793     +802     
- Misses        154      169      +15     
Impacted Files Coverage Δ
src/nd2/_util.py 86.66% <71.42%> (-3.90%) :arrow_down:
src/nd2/nd2file.py 89.06% <80.58%> (-4.81%) :arrow_down:
src/nd2/_legacy/_legacy.py 85.28% <81.81%> (ø)
src/nd2/_pysdk/_chunk_decode.py 84.44% <84.44%> (ø)
src/nd2/_binary.py 85.41% <85.41%> (ø)
src/nd2/_pysdk/_pysdk.py 91.18% <91.18%> (ø)
src/nd2/_clx_xml.py 92.10% <92.10%> (ø)
src/nd2/_pysdk/_parse.py 95.67% <95.67%> (ø)
src/nd2/structures.py 95.84% <96.90%> (-3.66%) :arrow_down:
src/nd2/_clx_lite.py 97.02% <97.02%> (ø)
... and 3 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

tlambert03 commented 1 year ago

some internal notes for myself... to keep track of what's going on here (copied here from https://github.com/tlambert03/nd2/pull/122#issue-1501961857)

tlambert03 commented 1 year ago

Everything is working and tests are passing. Going to merge this and do a little more cleanup in follow up PRs