tlambert03 / nd2

Full-featured nd2 (Nikon NIS Elements) file reader for python. Outputs to numpy, dask, and xarray. Exhaustive metadata extraction
https://tlambert03.github.io/nd2
BSD 3-Clause "New" or "Revised" License
52 stars 15 forks source link

test: fix aicsimageio test #188

Closed tlambert03 closed 10 months ago

codecov[bot] commented 10 months ago

Codecov Report

Merging #188 (d98f7d5) into main (ba78c7a) will increase coverage by 0.04%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
+ Coverage   95.35%   95.40%   +0.04%     
==========================================
  Files          17       17              
  Lines        2348     2348              
==========================================
+ Hits         2239     2240       +1     
+ Misses        109      108       -1     

see 1 file with indirect coverage changes

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

codspeed-hq[bot] commented 10 months ago

CodSpeed Performance Report

Merging #188 will degrade performances by 20.81%

Comparing fix-test (d98f7d5) with main (ba78c7a)

Summary

❌ 2 regressions ✅ 11 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix-test Change
test_time_imread_dask[train_TR67_Inj7_fr50] 580.3 ms 732.8 ms -20.81%
test_time_imread_dask[karl_sample_image] 2.1 s 2.6 s -18.3%