tlambert03 / nd2

Full-featured nd2 (Nikon NIS Elements) file reader for python. Outputs to numpy, dask, and xarray. Exhaustive metadata extraction
https://tlambert03.github.io/nd2
BSD 3-Clause "New" or "Revised" License
52 stars 15 forks source link

fix: access more frames via direct read_frame() method #192

Closed tlambert03 closed 10 months ago

tlambert03 commented 10 months ago

the file in #190 revealed a case where sometimes there are more frames available and readable than the product of the experiment axes. This PR makes those frames accessible by slightly relaxing the logic of the reader read_frame method.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5a7eb19) 95.40% compared to head (2289046) 95.43%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #192 +/- ## ========================================== + Coverage 95.40% 95.43% +0.03% ========================================== Files 17 17 Lines 2348 2346 -2 ========================================== - Hits 2240 2239 -1 + Misses 108 107 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codspeed-hq[bot] commented 10 months ago

CodSpeed Performance Report

Merging #192 will improve performances by 34.97%

Comparing read_frame (2289046) with main (5a7eb19)

Summary

⚡ 1 improvements ✅ 12 untouched benchmarks

Benchmarks breakdown

Benchmark main read_frame Change
test_time_imread[jonas_control002] 200.7 ms 148.7 ms +34.97%