search

tlambert03 / nd2

Full-featured nd2 (Nikon NIS Elements) file reader for python. Outputs to numpy, dask, and xarray. Exhaustive metadata extraction
https://tlambert03.github.io/nd2
BSD 3-Clause "New" or "Revised" License
52 stars 15 forks source link

fix: hacky fix for files with subloops #193

Closed tlambert03 closed 6 months ago

tlambert03 commented 10 months ago

This is a proof-of-principle hacky fix for the file that @aaristov shared in #190

@aaristov, if you're inclined, feel free to check out this branch and see if it works for you. I won't be merging this until I understand a bit better how that file ended up with this structure.

closes #190

codecov[bot] commented 10 months ago

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (8b2fd66) 95.49% compared to head (837b356) 95.16%.

Files Patch % Lines
src/nd2/_parse/_parse.py 27.27% 8 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #193 +/- ## ========================================== - Coverage 95.49% 95.16% -0.33% ========================================== Files 17 17 Lines 2308 2318 +10 ========================================== + Hits 2204 2206 +2 - Misses 104 112 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codspeed-hq[bot] commented 10 months ago

CodSpeed Performance Report

Merging #193 will not alter performance

Comparing subloops (837b356) with main (8b2fd66)

Summary

✅ 13 untouched benchmarks

aaristov commented 6 months ago

Hi Talley,

Just to let you know that you did a fantastic job and this branch works really well with the paused acquisitions, so I'd be happy to see it merged into production. Let me know if you need something before this happens.

Best Andrey

tlambert03 commented 6 months ago

Thanks @aaristov. I did end up getting some feedback from the folks at Laboratory Imaging, so I have a bit more info now on how to "properly" handle this unusual case. But, that proper way is even more convoluted :joy: hence my delay. But, if this is better than nothing, and you'd like to see it in, perhaps I'll just cut a release with this version, and then make more robust in a follow up.