tlambert03 commented 3 years ago

This PR includes the SDK in the repo. Permission was requested to distribute the SDK from LIM (license file included in SDK). There is no "formal" license, so a snippet of the email response was included.

This should help get it accepted at conda-forge, where it's currently blocked due to concerns about the source of the sdk: https://github.com/conda-forge/staged-recipes/pull/16462

it will also make it easier for people to test locally

codecov[bot] commented 3 years ago

Codecov Report

Merging #21 (dfdf1f4) into main (174a2b7) will decrease coverage by 0.83%. The diff coverage is 68.29%.

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
- Coverage   87.60%   86.77%   -0.84%     
==========================================
  Files          11       10       -1     
  Lines        1057     1066       +9     
==========================================
- Hits          926      925       -1     
- Misses        131      141      +10

Impacted Files	Coverage Δ
src/nd2/__init__.py	`100.00% <ø> (ø)`
src/nd2/_chunkmap.py	`57.14% <ø> (ø)`
src/nd2/_sdk/__init__.py	`100.00% <ø> (ø)`
src/nd2/_util.py	`92.45% <ø> (ø)`
src/nd2/_xml.py	`97.36% <ø> (ø)`
src/nd2/nd2file.py	`91.88% <ø> (ø)`
src/nd2/structures.py	`97.00% <ø> (ø)`
src/nd2/_legacy.py	`83.18% <33.33%> (ø)`
src/nd2/_sdk/latest.pyx	`84.87% <65.51%> (ø)`
src/nd2/_sdk/latest.pxd	`88.88% <88.88%> (ø)`
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 174a2b7...dfdf1f4. Read the comment docs.

tlambert03 commented 3 years ago

merging this, since it brings us back to where we currently are. I was hoping to address Centos7 stuff here (https://github.com/tlambert03/nd2/issues/16) but I'm not sure it's possible yet without help from LIM

tlambert03 / nd2

Include SDK, move to src layout #21

Codecov Report