Closed fdrgsp closed 8 months ago
I didn't see you did work on it already 🤣
Comparing fdrgsp:add_to_ome_tif
(f4d3a34) with main
(66f5bef)
✅ 13
untouched benchmarks
Aw shoot, you closed it! I did start working on it cause I wasn't sure if you had time to do it after all. But I think it's very cool to see the similarities in how we did it! I'm going to reopen this, probably merge it (cause I want you as a contributor), and then consider any additional features later.
One thing I played with is not using to_dask as an intermediate which keeps it a bit leaner and allows a progress feedback,
But thank you! Reopening
Attention: Patch coverage is 95.45455%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 95.17%. Comparing base (
66f5bef
) to head (f4d3a34
).
Files | Patch % | Lines |
---|---|---|
src/nd2/nd2file.py | 95.45% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
thanks for your work on this @fdrgsp! It was very helpful to compare what you did here to what I also stumbled across. I'm going to merge this in, and then reconcile it with #216
Hey @tlambert03 , I've started working on the conversion of the
nd2
files into theome-tif
format. It is definitely not finished but I think is a good starting point.I've added a
to_ome_tif()
method to the package to save to disk na.ome.tif
file and it is working as I want which means the I can also open the.ome.tif
files in Fiji and properly load theome
metadata (also with multi position files - in this case thebio-formats
importer asks the user to choose which series to open).One thing that I understood is that we need to rearrange the
ome
metadata gathered form thend2
ome_metadata()
method to create as manyImage
objects as the number of positions (grouped by the x, y position). At the moment this is done with the_reorganize_metadata()
function that I've added but maybe we can do that directly inome_metadata()
.When you have time can you have a look?
At the moment the test I've added only assert that the number of series in the tiff file is correct but it should be expanded as well.