search

tlambert03 / nd2

Full-featured nd2 (Nikon NIS Elements) file reader for python. Outputs to numpy, dask, and xarray. Exhaustive metadata extraction
https://tlambert03.github.io/nd2
BSD 3-Clause "New" or "Revised" License
53 stars 15 forks source link

add Dask-proxy #22

Closed tlambert03 closed 2 years ago

tlambert03 commented 2 years ago

lets the dask array returned from to_dask be opened even after the file has been closed (... it will reopen on compute())

tlambert03 commented 2 years ago

addresses part of https://github.com/tlambert03/nd2/issues/19 pulled from the proxy I made for aicsimageio

codecov[bot] commented 2 years ago

Codecov Report

Merging #22 (80dd178) into main (5e51447) will increase coverage by 0.56%. The diff coverage is 97.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   86.77%   87.34%   +0.56%     
==========================================
  Files          10       11       +1     
  Lines        1066     1106      +40     
==========================================
+ Hits          925      966      +41     
+ Misses        141      140       -1
Impacted Files Coverage Δ
src/nd2/_sdk/latest.pyx 84.54% <50.00%> (-0.34%) :arrow_down:
src/nd2/_dask_proxy.py 100.00% <100.00%> (ø)
src/nd2/nd2file.py 92.79% <100.00%> (+0.91%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5e51447...80dd178. Read the comment docs.

VolkerH commented 2 years ago

nice ! thanks