search

tlambert03 / nd2

Full-featured nd2 (Nikon NIS Elements) file reader for python. Outputs to numpy, dask, and xarray. Exhaustive metadata extraction
https://tlambert03.github.io/nd2
BSD 3-Clause "New" or "Revised" License
53 stars 15 forks source link

fix: Fix datetime extraction #226

Closed tlambert03 closed 5 months ago

tlambert03 commented 5 months ago

This PR fixes datetime extraction by not using text_info, and instead, casting the jdn time in the global metadata to the local timezone.

closes #221 closes #225

codspeed-hq[bot] commented 5 months ago

CodSpeed Performance Report

Merging #226 will not alter performance

Comparing fix-time (daf34e8) with main (0a46b98)

Summary

✅ 13 untouched benchmarks

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 95.45455% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.27%. Comparing base (0a46b98) to head (daf34e8).

Files Patch % Lines
src/nd2/_util.py 88.88% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #226 +/- ## ========================================== + Coverage 95.19% 95.27% +0.07% ========================================== Files 18 18 Lines 2436 2433 -3 ========================================== - Hits 2319 2318 -1 + Misses 117 115 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.