tlambert03 / nd2

Full-featured nd2 (Nikon NIS Elements) file reader for python. Outputs to numpy, dask, and xarray. Exhaustive metadata extraction
https://tlambert03.github.io/nd2
BSD 3-Clause "New" or "Revised" License
54 stars 15 forks source link

fix: fix for dask 2024.8 #240

Closed tlambert03 closed 2 months ago

tlambert03 commented 2 months ago

closes #239

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.97%. Comparing base (a515efd) to head (4ca706c). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #240 +/- ## ========================================== + Coverage 94.92% 94.97% +0.05% ========================================== Files 18 18 Lines 2424 2429 +5 ========================================== + Hits 2301 2307 +6 + Misses 123 122 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codspeed-hq[bot] commented 2 months ago

CodSpeed Performance Report

Merging #240 will degrade performances by 21.17%

Comparing fix-dask (4ca706c) with main (a515efd)

Summary

❌ 2 regressions ✅ 11 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix-dask Change
test_time_imread_dask[dims_p2z5t3-2c4y32x32] 60.1 ms 72.8 ms -17.43%
test_time_imread_dask[jonas_control002] 778.9 ms 988.1 ms -21.17%