search

tlaplus / CommunityModules

TLA+ snippets, operators, and modules contributed and curated by the TLA+ community
MIT License
273 stars 36 forks source link

WIP: IOExec enhancements #6

Closed lvanengelen closed 4 years ago

lvanengelen commented 4 years ago

The current IOExec has some problems handling quotes and spaces. This PR improves the situation by making IOExec just a small wrapper around Java's ProcessBuilder.

To keep the convenience of passing a string with %s placeholders, we introduce a new operator IOExecTemplate which takes a template string for the command. This template string is then split into words on which %s expansion takes place. This allows for spaces in the expanded strings. Note that for the sake of simplicity we don't handle

lemmy commented 4 years ago

Why did you close this PR?

lvanengelen commented 4 years ago

I had some trouble with GutHubs interface while rebasing on top of latest master. I thought I left it in Open state. Will look into it.

lvanengelen commented 4 years ago

Yeah, this one was closed by accident and I didn't find how to reopen it. I rebased properly on #7.