Closed ahelwer closed 1 year ago
Looks good to me. The KVS spec could use more comments.
@lemmy added a header comment in the KVS spec. Is this signoff/DCO thing a feature you enabled on this repo? Learning about it for the first time.
@lemmy added a header comment in the KVS spec. Is this signoff/DCO thing a feature you enabled on this repo? Learning about it for the first time.
DCO was recommended by the folks from the Linux Foundation as part of the onboarding process. Problems with it?
Nah just have to remember to add the -s flag to commits, it's fine.
Perhaps it is better to use your ...@users.noreply.github.com
email address in the sign-off?
I'm trying to avoid spam so I use my mozmail relay for commits on here. It's associated with my github account internally, which is why I get the verified tag on my commits (which are also signed with a U2F key). Although you're right, maybe I should use the noreply.github.com address instead; I'll look into it. I don't only use github, though. It would be strange to have a github email address on commits to gitlab or sourcehut, for example.
Merged, but something is wrong with the rendering of README.md.
Oh, hmm. Looks like the links aren't displaying. Slush should also be marked as a pluscal spec. Will fix in a few hours.