tlaplus / vscode-tlaplus

TLA+ language support for Visual Studio Code
MIT License
357 stars 33 forks source link

Enable extension in browser environments #286

Closed afonsonf closed 1 year ago

afonsonf commented 1 year ago

Hi, in this PR the extension is enabled for web environments such as vscode.dev and github.dev.

This is done by creating a new entrypoint for the extension where only a subset of the features is enabled, namely:

Changed to use npm compile instead of npm watch in extension debugging because to load changes the instance needs to be reload (does not reload automatically) and compile seems to work better and may solve this: https://github.com/tlaplus/vscode-tlaplus/pull/283#issuecomment-1522196174

References

lemmy commented 1 year ago

LGTM

afonsonf commented 1 year ago

I will try to fix the not working features this weekend, if I'm not able to do it, I'll clean up the MR to only include the highlighting to not block it to be enabled

afonsonf commented 1 year ago

Got it working, it was the document selector, for some reason in the browser it was not working for enabling the language features, so I changed it to use directly the language id strings. Also clean up the MR and removed the refactoring to have less changes

lemmy commented 1 year ago

Do we have to separately add the browser-version to the VSCode marketplace?

afonsonf commented 1 year ago

I don't think so, we can trigger the nightly release and check if the new one works

lemmy commented 1 year ago

https://github.com/tlaplus/vscode-tlaplus/actions/runs/4835623773

lemmy commented 1 year ago

Works like a charm, nicely done!

Screenshot 2023-04-28 at 4 42 55 PM