Closed afonsonf closed 1 year ago
LGTM
I will try to fix the not working features this weekend, if I'm not able to do it, I'll clean up the MR to only include the highlighting to not block it to be enabled
Got it working, it was the document selector, for some reason in the browser it was not working for enabling the language features, so I changed it to use directly the language id strings. Also clean up the MR and removed the refactoring to have less changes
Do we have to separately add the browser-version to the VSCode marketplace?
I don't think so, we can trigger the nightly release and check if the new one works
Works like a charm, nicely done!
Hi, in this PR the extension is enabled for web environments such as vscode.dev and github.dev.
This is done by creating a new entrypoint for the extension where only a subset of the features is enabled, namely:
Changed to use npm compile instead of npm watch in extension debugging because to load changes the instance needs to be reload (does not reload automatically) and compile seems to work better and may solve this: https://github.com/tlaplus/vscode-tlaplus/pull/283#issuecomment-1522196174
References