search

tlaukkan / vaadin-lazyquerycontainer

Lazy Query Container is a lazy loading container implementation for accessing data from business services.
http://vaadin.com/directory#addon/117
39 stars 73 forks source link

Add support for Vaadin 8 #101

Open mvysny opened 7 years ago

mvysny commented 7 years ago

Could you please add support for the now-released Vaadin 8? Having LQC compatible with Vaadin 8's v7.Grid would be awesome since it would allow gradual migration of the app using LQC towards Vaadin 8.

Thank you :+1:

mstahv commented 7 years ago

There actually seems to be a PR already available: https://github.com/tlaukkan/vaadin-lazyquerycontainer/pull/100

mvysny commented 7 years ago

Tested this patch and found it to be working. Reviewed the code - OK.

StefanPenndorf commented 7 years ago

Supporting Vaadin 8 is great but might require to maintain two branches - one for Vaadin 7 and one for Vaadin 8. We're forced to stay at Vaadin 7 for some time (our customers do not admit that IE8, IE9 and IE10 are almost dead). Would be bad if bugfixes and enhancements would not be available for LQC with Vaadin 7.