search

tlaukkan / zigbee4java

Zigbee API for Java provides simple Java interface to ZigBee network.
Apache License 2.0
144 stars 68 forks source link

Destination device address #101

Closed cdjackson closed 7 years ago

cdjackson commented 7 years ago

This is an updated version of #95. I've now updated the doc and removed commented code.

This changes the ZigBeeDestination to ZigBeeAddress, and then has two address classes - ZigBeeGroupAddress, and ZigBeeDeviceAddress. ZigBeeDevice no longer extends ZigBeeDestination - nothing relied on this extension, and it seems much better not to have this link.

It also makes ZigBeeAddress abstract, and then move the isGroup method into the implementation classes rather than having the parent class check for subclasses to see if it's a group which doesn't seem nice.

In general, everywhere where we had a network address and endpoint, I'm now using the address. It likely needs a bit more work, but I'd welcome your thoughts on wether or not you're happy with this approach.

cdealti commented 7 years ago

Hi guys I'm receiving tons of emails from Codacy with the following subject: Re: [tlaukkan/zigbee4java] Destination device address (#101) Is there a way to disable them without muting the thread?