tlaukkan / zigbee4java

Zigbee API for Java provides simple Java interface to ZigBee network.
Apache License 2.0
143 stars 68 forks source link

Error in zigbee api ( reporting command) #109

Closed han-alink closed 7 years ago

han-alink commented 7 years ago

MinReporting interval is set twice (instead of MIN and MAX

    record.setMinimumReportingInterval(minInterval);
    record.setMinimumReportingInterval(maxInterval);
    record.setReportableChange(reportableChange);
tlaukkan commented 7 years ago

Thank you Han for the bug reports. I try to look at this during the weekend. If you have pull requests those would be much appreciated. I have some other pull requests in queue to check as well.

han-alink commented 7 years ago

Hi Tommy,

Glad to hear that you are still actively working on the zigbee4java project.

I’m not familiar with “pull requests”. I imported zigbee4java in Eclipse and are using the software in combination with HomeRun (my home control program). I’m not yet finished with it yet, but can control my Zigbee devices already and get reports from the sensor devices. I added the “LevelContrallableOutput device” (deviceId = 3). I think you should rename the device with deviceId = 1 to LevelControlSwitch

I attached a patch file. This also contains some debugging statements which you should ignore. Have a close look and be warned: I’m not an expirienced java programmer!

Thanks for your effort,

Bset regards,

Han

Van: Tommi S.E. Laukkanen [mailto:notifications@github.com] Verzonden: dinsdag 29 november 2016 20:10 Aan: tlaukkan/zigbee4java CC: han-alink; Author Onderwerp: Re: [tlaukkan/zigbee4java] Error in zigbee api ( reporting command) (#109)

Thank you Han for the bug reports. I try to look at this during the weekend. If you have pull requests those would be much appreciated. I have some other pull requests in queue to check as well.

— You are receiving this because you authored the thread. Reply to this email directly, view https://github.com/tlaukkan/zigbee4java/issues/109#issuecomment-263667123 it on GitHub, or mute https://github.com/notifications/unsubscribe-auth/APXrXnCL1qSzYoQ3SESfWuh0hVS-FibXks5rDHiCgaJpZM4K-IeP the thread. https://github.com/notifications/beacon/APXrXh4cFzqk2YWpBgb9mWmsk2n-8Q7aks5rDHiCgaJpZM4K-IeP.gif