search

tlaukkan / zigbee4java

Zigbee API for Java provides simple Java interface to ZigBee network.
Apache License 2.0
144 stars 68 forks source link

Fix issue #76. #77

Closed cdealti closed 8 years ago

cdealti commented 8 years ago

Note that this commit reverts RESET_TIMEOUT_DEFAULT to 5s. First an attempt is made to reset the dongle. If timeout occurs we assume that the bootloader is running and we send the magic byte waiting for a SYS_RESET_RESPONSE. The magic byte is 0xef by default and configurable through a new zigbee.driver.cc2530.bl.magic.byte system property.

tlaukkan commented 8 years ago

Nice work and looks good to me.

cdealti commented 8 years ago

Thanks for reviewing this. About your first comment, I don't really like the overall configuration, a mix of system properties, constructor parameters and setters. I understand this was also the situation of zb4o but something is needed. We should consider a startup configuration object.

tlaukkan commented 8 years ago

Merge at will cdealti, you have the commit rights.