search

tlaukkan / zigbee4java

Zigbee API for Java provides simple Java interface to ZigBee network.
Apache License 2.0
144 stars 68 forks source link

Fix POM and remove test from old API #99

Closed cdjackson closed 7 years ago

cdjackson commented 7 years ago

I just grabbed a clean fork of the repo to tidy things up a bit, and it looks like the pom is broken and some tests refer to the old API. This just tidies this up - maybe it was like that for a reason, but when starting from a fresh fork, it doesn't work currently. Signed-off-by: Chris Jackson chris@cd-jackson.com

tlaukkan commented 7 years ago

Hi

The old API should remain functional for backwards compatibility over one major release at least. Is the build broken. I think master has been passing ok with CI build.

Br, tommi

On Mon, Aug 29, 2016 at 8:05 PM, Chris Jackson notifications@github.com wrote:

I just grabbed a clean fork of the repo to tidy things up a bit, and it looks like the pom is broken and some tests refer to the old API. This just tidies this up - maybe it was like that for a reason, but when starting from a fresh fork, it doesn't work currently.

Signed-off-by: Chris Jackson chris@cd-jackson.com

You can view, comment on, or merge this pull request online at:

https://github.com/tlaukkan/zigbee4java/pull/99 Commit Summary

  • Fix POM and remove test from old API

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tlaukkan/zigbee4java/pull/99, or mute the thread https://github.com/notifications/unsubscribe-auth/AAONRinGQy0vVhvtB4ibS4GsqYPpiIQ8ks5qkxFLgaJpZM4Jvrjw .

Best regards, Tommi Laukkanen

cdjackson commented 7 years ago

The pom doesn’t seem to depend on the serial library which stops it working here. That was the main problem I had to get it running from scratch.

tlaukkan commented 7 years ago

Ah right, because of the move of the serial interface.

cdjackson commented 7 years ago

I’m not sure what you’re referring to - if you mean the other discussion on the location of the SerialPort interface, then that shouldn’t be relevant as that’s in another branch. This was an issue in master. Maybe it’s just an eclipse issue if you actually want to run the software.

tlaukkan commented 7 years ago

Ok, just made the connection because when I was looking into pull request and was wondering if it will compile due to dependecy problems.