search

tlaverdure / laravel-echo-server

Socket.io server for Laravel Echo
MIT License
2.64k stars 509 forks source link

Add the user-agent and the remote address ip #546

Open huguesjoyal opened 3 years ago

huguesjoyal commented 3 years ago

When using the Private channel, laravel-echo-server is sending a request to the apps (/broadcasting/auth). The user agent being empty and the remote address being the laravel-echo-server, the session is updated with the new info, which can cause a problem when using database sessions.

Here is an example problem : https://laracasts.com/discuss/channels/laravel/user-session-user-agent-and-ip-address-fields-are-corrupt-when-using-laravel-echo-server

My suggestion is to add an X-Forwarded-For with the remote client IP and add the User-Agent.

To get the correct client IP address on the laravel side, we need to set up the laravel-echo-server IP address as a trusted proxy. https://laravel.com/docs/master/requests#configuring-trusted-proxies

PaolaRuby commented 2 years ago

@tlaverdure could be merged?

parallels999 commented 2 years ago

@tlaverdure ping , hi??