tlawrence3 / tSFM

Other
0 stars 3 forks source link

Firstdraft #1

Closed fhadinezhadUC closed 4 years ago

tlawrence3 commented 5 years ago

This is a good start, however, it needs some work to conform to the current design of tsfm. I will post more detailed comments tomorrow. For now, the easiest thing to address is removing the .idea directory from commits. This seems to possibly be config files from an IDE.

fhadinezhadUC commented 5 years ago

Okay it is removed now! it was hidden for me. what IDE are you using for python? I was using PyCharm trial and it will be expired in 2 days.

On Thu, Jan 17, 2019 at 7:41 PM Travis Lawrence notifications@github.com wrote:

This is a good start, however, it needs some work to conform to the current design of tsfm. I will post more detailed comments tomorrow. For now, the easiest thing to address is removing the .idea directory from commits. This seems to possibly be config files from an IDE.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tlawrence3/tsfm/pull/1#issuecomment-455417531, or mute the thread https://github.com/notifications/unsubscribe-auth/Ak8LldcX70UZBeIeH_Tsal4kwayng653ks5vEUJcgaJpZM4aHJHh .

--

Fatemeh Hadi nezhadGraduate Student Researcher Quantitative and system biology University of California, Merced

Phone: (812) 243-5262

tlawrence3 commented 5 years ago

I am using vim with a couple plugins like any rational individual.

Sent via the Samsung Galaxy Note8, an AT&T 4G LTE smartphone

-------- Original message -------- From: fhadinezhadUC notifications@github.com Date: 1/17/19 10:54 PM (GMT-05:00) To: tlawrence3/tsfm tsfm@noreply.github.com Cc: Travis Lawrence tlawrence3@ucmerced.edu, Comment comment@noreply.github.com Subject: Re: [tlawrence3/tsfm] Firstdraft (#1)

Okay it is removed now! it was hidden for me. what IDE are you using for python? I was using PyCharm trial and it will be expired in 2 days.

On Thu, Jan 17, 2019 at 7:41 PM Travis Lawrence notifications@github.com wrote:

This is a good start, however, it needs some work to conform to the current design of tsfm. I will post more detailed comments tomorrow. For now, the easiest thing to address is removing the .idea directory from commits. This seems to possibly be config files from an IDE.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tlawrence3/tsfm/pull/1#issuecomment-455417531, or mute the thread https://github.com/notifications/unsubscribe-auth/Ak8LldcX70UZBeIeH_Tsal4kwayng653ks5vEUJcgaJpZM4aHJHh .

--

Fatemeh Hadi nezhadGraduate Student Researcher Quantitative and system biology University of California, Merced

Phone: (812) 243-5262

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/tlawrence3/tsfm/pull/1#issuecomment-455419450, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFfhpph34M1OIVrchLVTLH0aPrm3hlq7ks5vEUWKgaJpZM4aHJHh.

fhadinezhadUC commented 5 years ago

rational or old fashioned ? LOL! Well, I was using vim and gedit at first but it was keep giving me errors for the indentations. PyCharm is pretty good! I look forward to your comments tomorrow. Thanks

On Thu, Jan 17, 2019 at 7:57 PM Travis Lawrence notifications@github.com wrote:

I am using vim with a couple plugins like any rational individual.

Sent via the Samsung Galaxy Note8, an AT&T 4G LTE smartphone

-------- Original message -------- From: fhadinezhadUC notifications@github.com Date: 1/17/19 10:54 PM (GMT-05:00) To: tlawrence3/tsfm tsfm@noreply.github.com Cc: Travis Lawrence tlawrence3@ucmerced.edu, Comment < comment@noreply.github.com> Subject: Re: [tlawrence3/tsfm] Firstdraft (#1)

Okay it is removed now! it was hidden for me. what IDE are you using for python? I was using PyCharm trial and it will be expired in 2 days.

On Thu, Jan 17, 2019 at 7:41 PM Travis Lawrence notifications@github.com wrote:

This is a good start, however, it needs some work to conform to the current design of tsfm. I will post more detailed comments tomorrow. For now, the easiest thing to address is removing the .idea directory from commits. This seems to possibly be config files from an IDE.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tlawrence3/tsfm/pull/1#issuecomment-455417531, or mute the thread < https://github.com/notifications/unsubscribe-auth/Ak8LldcX70UZBeIeH_Tsal4kwayng653ks5vEUJcgaJpZM4aHJHh

.

--

Fatemeh Hadi nezhadGraduate Student Researcher Quantitative and system biology University of California, Merced

Phone: (812) 243-5262

— You are receiving this because you commented. Reply to this email directly, view it on GitHub< https://github.com/tlawrence3/tsfm/pull/1#issuecomment-455419450>, or mute the thread< https://github.com/notifications/unsubscribe-auth/AFfhpph34M1OIVrchLVTLH0aPrm3hlq7ks5vEUWKgaJpZM4aHJHh

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tlawrence3/tsfm/pull/1#issuecomment-455419819, or mute the thread https://github.com/notifications/unsubscribe-auth/Ak8LlTWszhLT0GOdtIQ_xadwcxefGMH-ks5vEUY-gaJpZM4aHJHh .

--

Fatemeh Hadi nezhadGraduate Student Researcher Quantitative and system biology University of California, Merced

Phone: (812) 243-5262

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at ?% when pulling 8c06edb3f8efbe70407fd75fd00af22a1c46094c on fhadinezhadUC:firstdraft into 7681e19fb816c1ccc34ae38c57c526082a0b65cf on tlawrence3:master.