search

tlc-pack / relax

Apache License 2.0
193 stars 58 forks source link

[Analysis][Tweak] Simplify dataflow block tracking in inner functions for the well-formed analysis #374

Closed slyubomirsky closed 1 year ago

slyubomirsky commented 1 year ago

This PR makes a small tweak on the changes in #370. #370 keeps an explicit stack to handle the case of a local function being defined inside a dataflow block. However, this is more complicated than it needs to be: it suffices to keep a single flag for whether the visitor is inside a dataflow block and to save the value of the flag before recursing into a local function definition, similarly to how it handles the var sets.

(I realized that the code could be simplified immediately after it was merged :sweat:)

slyubomirsky commented 1 year ago

Weird. Will do

slyubomirsky commented 1 year ago

Force pushing doesn't work if there isn't a change so I will see if the CI bot will work.

MasterJH5574 commented 1 year ago

Force pushing doesn't work if there isn't a change so I will see if the CI bot will work.

git commit --amend with the same commit message + force push should work, as this mutates the commit.

slyubomirsky commented 1 year ago

Very clever