Previously when running all relax unit tests on my machine using pytest test_*, one auto argument converter tests always fail. (And when I only run that single test, it passes very well.)
I tweaked the comparison to in and all tests seem to pass very successfully. I guess the issue might relate to some address issue (?) but I’m not 100% sure about this.
Previously when running all relax unit tests on my machine using
pytest test_*
, one auto argument converter tests always fail. (And when I only run that single test, it passes very well.)After inspection, I noted that in the failed test, though
anno
is printed astyping.Optional[tvm.ir.expr.RelayExpr]
, the comparison belowanno is Optional[Expr]
still results false. https://github.com/tlc-pack/relax/blob/2e5e47962238be7385486241203d1a8146f38a0e/python/tvm/relax/utils.py#L252-L253I tweaked the comparison to
in
and all tests seem to pass very successfully. I guess the issue might relate to some address issue (?) but I’m not 100% sure about this.cc @Hzfengsy