search

tlc-pack / relax

Apache License 2.0
193 stars 58 forks source link

Move PyVisitor/Mutator into cc file #398

Closed LeshengJin closed 1 year ago

LeshengJin commented 1 year ago

299

Move PyExprVisitor/Mutator from expr_functor.h to expr_functor.cc

cc @YuchenJin @tqchen @junrushao

tqchen commented 1 year ago

Thanks @LeshengJin ! is it possible to move into an independent file py_expr_functor.cc?

LeshengJin commented 1 year ago

is it possible to move into an independent file py_expr_functor.cc?

Yes, that's much better! Moved them into py_expr_functor.cc.

Thanks for the reviews @Hzfengsy @tqchen

tqchen commented 1 year ago

Thank you @LeshengJin !