tlc-pack / relax

Apache License 2.0
193 stars 58 forks source link

Cleanup remaining low-level intrinsics that uses Attrs to use PrimValue #405

Closed tqchen closed 1 year ago

tqchen commented 1 year ago

After https://github.com/tlc-pack/relax/pull/392, we cleaned up CallBuiltin.

It would be great migrate the rest of the low-level intrinsics to use PrimValue, these functions include

slyubomirsky commented 1 year ago

Are we removing attributes entirely from the language?

tqchen commented 1 year ago

I don't think we will remove Attrs entirely atm, but for some of the low-level ops that have special codegen behaviors, moving them to use PrimValue would be more beneficial(so we can for example leverage same codegen for compiled and vm)

slyubomirsky commented 1 year ago

That seems reasonable, thanks.