[BYOC] Fix problems in MergeCompositeFunctions

tlc-pack / relax

Apache License 2.0

193 stars 58 forks source link

[BYOC] Fix problems in MergeCompositeFunctions #411

Closed yelite closed 1 year ago

yelite commented 1 year ago

This PR fixes a few issues in the MergeCompositeFunctions:

CompositeInliner will caches inlined function so the same function will not be inlined twice in the merged function.
It now uses proper union join and dependency analysis, which will:
- Prevent cyclic dependencies when merging two arg groups of the call.
- Properly merge a long chain of calls into the same group.

cc @masahi

masahi commented 1 year ago

@yelite Please update the comment in https://github.com/tlc-pack/relax/blob/b5a9c505524f9e73c589ec7c7b38046d97b0f274/src/relax/transform/merge_composite_functions.cc#L47-L48

yelite commented 1 year ago

@yelite Please update the comment in

https://github.com/tlc-pack/relax/blob/b5a9c505524f9e73c589ec7c7b38046d97b0f274/src/relax/transform/merge_composite_functions.cc#L47-L48

It's updated.