search

tlc-pack / relax

Apache License 2.0
193 stars 58 forks source link

[Tweak] Note that `PrimValue`, `DataTypeImm`, and `StringImm` are leaf nodes #423

Closed slyubomirsky closed 1 year ago

slyubomirsky commented 1 year ago

Our comments in the well-formed pass did not mention PrimValue, DataTypeImm, and StringImm as leaf nodes. This PR updates the comment and adds a test case demonstrating this fact.

tqchen commented 1 year ago

They are actually considered because they are all subclass of LeafExprNode

slyubomirsky commented 1 year ago

Oh okay, we don't need to change the definition of IsLeafOrTuple then. We can keep the new test case and the comment updates