Closed gigiblender closed 2 years ago
sorry; approved the GH workflows to run, let's merge depending on how they look
sorry; approved the GH workflows to run, let's merge depending on how they look
Seems like I need to build new docker images.
@gigiblender also i think the workflows are silently failing. i think we discuss this was in case we need to patch up some tests...if they are all passing maybe we should remove || true
and just start failing workflows when tests fail?
for the failing tests maybe we should file issues and add a pytest.mark.skipIf(os.getenv("WHEEL_TEST", "")...)
on the actual test in apache/tvm so we can avoid the silent failures
@areusch @driazati. As advised, I created https://github.com/apache/tvm/pull/11705 and removed the || true
condition.
Could you please have another look? I will create an issue listing the failing tests as well.
thanks @gigiblender , @driazati want to have a look?
https://github.com/apache/tvm/pull/11969 needs to get merged to (hopefully) pass all the tests
Ok, I think this is all good now.
thanks @gigiblender i can see the tests running in wheel-manylinux-nightly. could you resolve the merge conflict and then i think we can merge? sorry if i let this become stale.
thanks @gigiblender i can see the tests running in wheel-manylinux-nightly. could you resolve the merge conflict and then i think we can merge? sorry if i let this become stale.
Done
This PR runs the python unit tests as part of the nightly build.
Since at the moment there are some failing tests, I do an
|| true
to ignore the return code of therun_tests.sh
command and keep the green tick-mark in the actions section.@areusch