tlc-pack / tlcpack

https://tlcpack.ai/
Apache License 2.0
23 stars 30 forks source link

Run tests in wheel #115

Closed gigiblender closed 2 years ago

gigiblender commented 2 years ago

This PR runs the python unit tests as part of the nightly build.

Since at the moment there are some failing tests, I do an || true to ignore the return code of the run_tests.sh command and keep the green tick-mark in the actions section.

@areusch

areusch commented 2 years ago

sorry; approved the GH workflows to run, let's merge depending on how they look

gigiblender commented 2 years ago

sorry; approved the GH workflows to run, let's merge depending on how they look

Seems like I need to build new docker images.

areusch commented 2 years ago

@gigiblender also i think the workflows are silently failing. i think we discuss this was in case we need to patch up some tests...if they are all passing maybe we should remove || true and just start failing workflows when tests fail?

driazati commented 2 years ago

for the failing tests maybe we should file issues and add a pytest.mark.skipIf(os.getenv("WHEEL_TEST", "")...) on the actual test in apache/tvm so we can avoid the silent failures

gigiblender commented 2 years ago

@areusch @driazati. As advised, I created https://github.com/apache/tvm/pull/11705 and removed the || true condition.

Could you please have another look? I will create an issue listing the failing tests as well.

areusch commented 2 years ago

thanks @gigiblender , @driazati want to have a look?

gigiblender commented 2 years ago

https://github.com/apache/tvm/pull/11969 needs to get merged to (hopefully) pass all the tests

gigiblender commented 2 years ago

Ok, I think this is all good now.

areusch commented 2 years ago

thanks @gigiblender i can see the tests running in wheel-manylinux-nightly. could you resolve the merge conflict and then i think we can merge? sorry if i let this become stale.

gigiblender commented 2 years ago

thanks @gigiblender i can see the tests running in wheel-manylinux-nightly. could you resolve the merge conflict and then i think we can merge? sorry if i let this become stale.

Done