tlc-pack / tlcpack

https://tlcpack.ai/
Apache License 2.0
23 stars 30 forks source link

Nightly build broke due to outdated CMake version #138

Closed PhilippvK closed 1 year ago

PhilippvK commented 1 year ago

Since https://github.com/apache/tvm/commit/8c88aab77863e43985318c575a2fa648fc783338 TVM requires CMake version 3.18 or higher which led to failing CI jobs in the tlcpack repo. While the latest CMake version is installed into the containers (see centos_install_cmake.sh) the System version of CMake is used instead of the manually installed one.

To fix the CI up to 5 steps are required:

  1. Update centos_install_cmake.sh to add the installed CMake version to the SYSTEM path. Alternative: build a specific version of CMake from source similarly to https://github.com/apache/tvm/blob/main/docker/install/ubuntu_install_cmake_source.sh
  2. Build new Docker images using the fix
  3. Tag a new version for the newly build images on Dockerhub (Optional if we just want to use the SHA1 of the latest image instead)
  4. Update https://github.com/tlc-pack/tlcpack/blob/main/.github/workflows/wheel_manylinux_nightly.yaml#L20:L30 etc. to use the updated images
driazati commented 1 year ago

2 and 3 will happen automatically with https://github.com/tlc-pack/tlcpack/actions/runs/3275287205, so once that's done we can update the images in the workflows

PhilippvK commented 1 year ago

@driazati Should I then just use tlcpack/package-cpu:bf872ef etc. or can we create a tag for this such as v0.6?

driazati commented 1 year ago

just the hash is probably fine, the version number doesn't add much meaning imo