tlc-pack / tlcpack

https://tlcpack.ai/
Apache License 2.0
23 stars 30 forks source link

[CI] fix broken handling of release candidates in wheel_prune_and_sync.py script #146

Closed PhilippvK closed 1 year ago

PhilippvK commented 1 year ago

It seems like the "Prune-Nightly" job broke yesterday: https://github.com/tlc-pack/tlcpack/actions/runs/3327332266/jobs/5502020456

Traceback (most recent call last):
  File "/home/runner/work/tlcpack/tlcpack/wheel/wheel_prune_and_sync.py", line 172, in <module>
    main()
  File "/home/runner/work/tlcpack/tlcpack/wheel/wheel_prune_and_sync.py", line 163, in main
    group_map = group_wheels(wheels)
  File "/home/runner/work/tlcpack/tlcpack/wheel/wheel_prune_and_sync.py", line 63, in group_wheels
    gkey, order = extract_group_key_order(asset.name)
  File "/home/runner/work/tlcpack/tlcpack/wheel/wheel_prune_and_sync.py", line 50, in extract_group_key_order
    pub_ver = [int(x) for x in ver[:dev_pos].split(".")]
  File "/home/runner/work/tlcpack/tlcpack/wheel/wheel_prune_and_sync.py", line 50, in <listcomp>
    pub_ver = [int(x) for x in ver[:dev_pos].split(".")]
ValueError: invalid literal for int() with base 10: '0rc0'

See:

This should allow the script to deal with rcs in the version numbers.

@driazati

tqchen commented 1 year ago

Thanks @PhilippvK . One thing to note as well is that ideally we should not release rc as part of the wheels in this case and use the tags that are validated

PhilippvK commented 1 year ago

@tqchen I share your opinion. However I do not know where to filter them out. It also seems like there is currently no stable wheel built for TVM v0.10.0.

tqchen commented 1 year ago

@PhilippvK agree, so i think it is helpful to include the change

PhilippvK commented 1 year ago

@tqchen

tqchen commented 1 year ago

Going to merge this in for now given that it is still good to recognize rc.

Once we have stable build updated, we can them update the logic, e.g. making sure stable build being able to take precedence of rc and filter them out