tlc-pack / tlcpack

https://tlcpack.ai/
Apache License 2.0
23 stars 30 forks source link

Fix Python version check when Conda not installed #148

Closed Liam-Sturge closed 1 year ago

Liam-Sturge commented 1 year ago

When running tlcpack on build environments that do not have Conda installed, the script is failing due to the method used to locate the Python version.

5382fa075932676938728a241e21bfcb8e714ea1 changed the way in which the Python version is located, now hard-coding a path that only exists in environments where Conda has been installed.

I have added a check to fall back to the previous method of locating the Python version on environments where Conda is not installed.

CC @leandron @driazati @areusch @Mousius for review

driazati commented 1 year ago

CI failures look unrelated to this PR, a bunch of cancellations from GitHub (looks like the runner ran out of space?): https://github.com/tlc-pack/tlcpack/actions/runs/3411250284

leandron commented 1 year ago

The CI failures are unrelated to this PR, so I'm merging it to unblock builds using the cpu_aarch64 image.