tlc-pack / tlcpack

https://tlcpack.ai/
Apache License 2.0
23 stars 30 forks source link

Cut daily Docker image validate trigger from Jenkins pipeline #176

Closed Liam-Sturge closed 1 year ago

Liam-Sturge commented 1 year ago

Since work was completed to split up Jenkins in to platform-specific jobs (PR: https://github.com/apache/tvm/pull/13316), the pipeline for validating the docker images with tests has been failing.

It doesn't appear this validation pipeline is still needed. We can disable it to save on compute resources, however in doing so, it causes a failure of the daily-docker-image-rebuild pipeline, which triggers the validation pipeline to be run if the build is successful. This is because the validation pipeline relied on the file JenkinsFile, which was removed as part of the changes mentioned above.

In order to resolve the build errors for the daily docker rebuild, it is necessary to remove the trigger for the validation pipeline.

cc @areusch @konturn @Mousius @leandron @tqchen

leandron commented 1 year ago

Merging this to unblock the builds. I think it worth also consider removing the pipelines that are not expected to work anymore.

Any thoughts @tqchen @areusch?

areusch commented 1 year ago

no concerns with deleting broken code that isn't getting maintained from CI