search

tlc-pack / tlcpack

https://tlcpack.ai/
Apache License 2.0
23 stars 30 forks source link

[CI] [Mac] Failure to compile Cython for deplyment target MacOS #185

Closed Liam-Sturge closed 11 months ago

Liam-Sturge commented 11 months ago

Expected behavior

The CI Github actions workflow defined in wheel_winmac_nightly.yaml will compile Cython successfully and complete the build without failure.

Actual behavior

The CI builds for Mac fail because the expected deployment target with Cython v0.29.34 is MacOS v11.7. The wheel_winmac_nightly.yaml file specifies that the deployment target will be MacOS v10.15, which is incompatible. This is not actually recorded in the logs, but the failure happens when

Background information

Cython v3.0.0 was recently released (https://github.com/cython/cython/releases/tag/3.0.0) and is used in newly built docker images. This causes a compilation issue since 3.0.0 expects function definitions to be explicitly declared with the noexcept annotation. This change should be backwards compatible to v0.29.31. For more details see the discussion here: https://github.com/scipy/scipy/issues/17234#issuecomment-1493423202.

We can workaround this Cython problem by pinning the version to v0.29.34, but this introduces the issue described above.

Environment

CI - Wheel-WinMac-Nightly

tqchen commented 11 months ago

With https://github.com/apache/tvm/pull/15469 Hopefully we can get up to speed with cython3 and remove the pinning