search

tlc-pack / tlcpack

https://tlcpack.ai/
Apache License 2.0
23 stars 30 forks source link

Support Linux Nightly Build for Pip #33

Closed mshawcroft closed 3 years ago

mshawcroft commented 3 years ago

Just noticed the nice form on https://tlcpack.ai but noticed that for pip, linux, no-cuda the form points to "build from source instruction" rather than recommending "pip install", switching to "Mac" and it does recommend pip install. This is a bit surprising, any idea what's gone wrong?

mshawcroft commented 3 years ago

Maybe this isn't the write forum to discuss https://tlcpack.ai/, in which case please redirect me...

tqchen commented 3 years ago

This is simply because we haven't yet work on the workflow for linux(need a manylinux setup). It be updated once @icemelon9 updates the linux wheel script

leandron commented 3 years ago

@tqchen @icemelon9 do you think we could use something like https://github.com/RalfG/python-wheels-manylinux-build to trigger GitHub actions in a manylinux environment? Or do you have something else in mind to solve this issue?

tqchen commented 3 years ago

@leandron the technical solutions are as follows:

I believe the delay is mainly due to @icemelon9 being busy and not able to get to these steps. My guess is that they would cost about a few days of work. Please let me know if you are interested in helping out.

tqchen commented 3 years ago

gentle ping @leandron @icemelon9

hogepodge commented 3 years ago

I'm starting take a look at this issue and will see if we can enable the builds soon.

hogepodge commented 3 years ago

These two patches are the first steps in supporting Linux Nightly Pip https://github.com/tlc-pack/tlcpack/pull/43 https://github.com/tlc-pack/tlcpack/pull/44

Once these land, I can send up a workflow patch that build nightly against the main branch. Stable won't build, as Ethos driver is incompatible with it.

tqchen commented 3 years ago

linux nightly is now available