Fix GitHub API usage to get minor LLVM version from releases API.

tlc-pack / tlcpack

https://tlcpack.ai/

Apache License 2.0

23 stars 30 forks source link

Fix GitHub API usage to get minor LLVM version from releases API. #77

Closed leandron closed 2 years ago

leandron commented 2 years ago

Fix GitHub API usage to get minor LLVM version from releases API.

By default, the API returns the first 30 results. As the version we use gets older, we now need to get more results for 10.x to appear in the results. This breaks the way we resolve LLVM versions to be built
This change increase the number of results from 30 to 50

Reference for the parameters being used: https://docs.github.com/en/rest/reference/repos#releases

cc @icemelon @tqchen @areusch @Mousius for reviews

leandron commented 2 years ago

Happy with this as an intermediate solution, we should definitely consider fixing this to a specific version at some point to avoid this kind of weird behaviour and ensure stability.

Yes, I'm in favour of moving to just a static version number, which has less dependencies and still would just move us minor versions. I didn't want to do both changes in this single PR. What do you think @tqchen ?