search

tldr-group / taufactor

TauFactor is a parallelised solver for calculating tortuosity factors from voxel data.
MIT License
28 stars 5 forks source link

JOSS review: Tortuosity factor should always be greater than 1? #79

Closed ma-sadeghi closed 1 year ago

ma-sadeghi commented 1 year ago

In of of the unit tests, tortuosity factor is less than 1. I was under the impression that tortuosity should always be greater than 1. Could you please explain?

https://github.com/tldr-group/taufactor/blob/abd2877ba205badcb24a68b89e76927d8e4e5a14/tests/test_taufactor.py#L318-L328

stke9 commented 1 year ago

taue, electrode tortuosity, is not always greater than 1, please see https://www.nature.com/articles/s41524-020-00386-4. Thanks!

LDXu93 commented 1 year ago

I submitted a similar issue at https://github.com/tldr-group/taufactor/issues/76 last week, according to the npj paper, $tau$, not $tau_e$, should be infinity for a single dead end pore, right? but I got some number smaller than 1.

stke9 commented 1 year ago

Hi Lex, I'm working on your issue right now (it's a problem that arose when we changed the convergence criteria), sorry have been waiting for reviews to come back!