search

tldr-group / taufactor

TauFactor is a parallelised solver for calculating tortuosity factors from voxel data.
MIT License
29 stars 6 forks source link

JOSS review: Some docstrings of the unit tests needs revision #80

Closed ma-sadeghi closed 1 year ago

ma-sadeghi commented 1 year ago

This is very minor, just for completeness: Could you please revise the docstrings of the unit tests? Some of them don't reflect what the unit test does like:

https://github.com/tldr-group/taufactor/blob/abd2877ba205badcb24a68b89e76927d8e4e5a14/tests/test_taufactor.py#L318-L319

and

https://github.com/tldr-group/taufactor/blob/abd2877ba205badcb24a68b89e76927d8e4e5a14/tests/test_taufactor.py#L330-L331

stke9 commented 1 year ago

Done and added a few missing, thanks!