tldr-pages / tldr-c-client

C command-line client for tldr pages 📚

MIT License

299 stars 50 forks source link

Change the way update_localdb() works #100

Closed ar7eniyan closed 1 year ago

ar7eniyan commented 1 year ago

What does it do?

Makes the update of a local database not use /tmp/tldrXXXXXX temp directory, but download the update archive to a temporary place inside a tldr home directory (currently ~/.tldrc/tmp/), which omits painful cross-FS file manipulation.

Why the change?

Makes the local database work on systems where /tmp/ and $HOME are on different partitions. Resolves #95.

How can this be tested?

Remove tldr home folder (~/.tldrc) and run tldr -u

Where to start code review?

https://github.com/tldr-pages/tldr-c-client/pull/100/commits/c8424d422b9229b7c05b1c061547331ca5cde92a

Relevant tickets?

95

Questions?

C isn't my primary language, so any corrections are welcome.

ar7eniyan commented 1 year ago

Is there any maintainer to review the PR?

github-actions[bot] commented 1 year ago

Hi all! This thread has not had any recent activity. Are there any updates? Thanks!