search

tldr-pages / tldr-c-client

C command-line client for tldr pages
MIT License
296 stars 49 forks source link

rename the repo to tldr-c-client #20

Closed waldyrious closed 4 years ago

waldyrious commented 7 years ago

to match the documentation

Leandros commented 7 years ago

While this would match the documentation, we can't do that unfortunately. It would break all of our past homebrew taps including the core.

waldyrious commented 7 years ago

I believe github keep redirects in place, but I'm not sure. If that is the case, would it work?

Leandros commented 7 years ago

They keep a redirect in place, but it's undocumented and might break randomly. There is a big red warning when I try to rename the repository.

waldyrious commented 7 years ago

I see. That's a pity. I guess the only way to handle this is to create a separate repo and mark this one as deprecated, but that would lose the issue history, and is generally a sub-optimal solution. Feel free to pick what choice seems more appropriate, including closing this issue.

isaachier commented 6 years ago

Old issue has an older solution: https://github.com/blog/1508-repository-redirects-are-here

zlatanvasovic commented 4 years ago

ping @waldyrious @sbrl

The client is also wrongly stated as C++ client in tldr-pages/tldr's README.

sbrl commented 4 years ago

I'd be able to move the repo if we could co-ordinate homebrew.

We should also update the README there then, yeah

agnivade commented 4 years ago

I am wondering why this was named cpp client in the first place. Was there C++ code initially, which was replaced with C ?

waldyrious commented 4 years ago

I'd be able to move the repo if we could co-ordinate homebrew.

AFAIK Homebrew does not support installing old versions of a formula anyway, so we would just need to submit a PR updating the tldr formula to match the new repo URL.

zlatanvasovic commented 4 years ago

@agnivade Seems like your hypothesis is right. https://github.com/tldr-pages/tldr-cpp-client/commit/813c5fb588baf217914006aaed8bb697d7c2d13b#diff-3817fa6a8ba7236b52bad41400452877

zlatanvasovic commented 4 years ago

@agnivade @sbrl @owenvoke @mebeim Once the repo is renamed, GitHub will automatically redirect old URLs to the new ones. Basically all that's required to be done is to simply rename the repository.

After that related URLs can be changed in https://github.com/Homebrew/homebrew-core/blob/master/Formula/tldr.rb.

Leandros commented 4 years ago

I am wondering why this was named cpp client in the first place. Was there C++ code initially, which was replaced with C ?

Yes, this was originally in C++. I switched it to C at a later point to, eventually, support Windows. Which I never actually got around to implement, unfortunately.

sbrl commented 4 years ago

@Leandros: ....but Windows has a C++ compiler?

owenvoke commented 4 years ago

I think it's ok to finally close this. 👍 The repo has been renamed, references in Brew have been updated, and everything seems to be working as expected.