search

tldr-pages / tldr-c-client

C command-line client for tldr pages
MIT License
296 stars 49 forks source link

replace master with main #59

Closed marchersimon closed 2 years ago

marchersimon commented 3 years ago

As far as I know, the master to main change shouldn't affect any client, however it broke the C client. I always get Error: Could Not Rename: /tmp/tldr70oDX4/tldr-master to /home/user/.tldrc/tldr-master/ and /tmp/tldr70oDX4/ just doesn't exist.

However after changing everything to main it works again.

bl-ue commented 3 years ago

https://github.com/tldr-pages/tldr-c-client/pull/56#issuecomment-761781479

marchersimon commented 3 years ago

Ah, I see. But I think this should be done quickly since right now, the client is broken (at least for me). Also, I don't think it would be a big problem creating tldr-main, even if tldr-master exists. It is by far the easiest solution and it's merely an additional 36 MiB.

owenvoke commented 3 years ago

@marchersimon, I think maybe it should just be tldr instead of tldr-main, and we can do the cleanup/migration after?

marchersimon commented 3 years ago

Done

github-actions[bot] commented 3 years ago

Hi all! This thread has not had any recent activity. Are there any updates? Thanks!

CleanMachine1 commented 3 years ago

could we not mirror the branches

marchersimon commented 3 years ago

@owenvoke can we merge this?

owenvoke commented 3 years ago

This seems fine to me. However, I don't use the C client, so not entirely sure. 👍🏻

marchersimon commented 3 years ago

@sbrl @CleanMachine1 any thoughts?

github-actions[bot] commented 3 years ago

Hi all! This thread has not had any recent activity. Are there any updates? Thanks!

CleanMachine1 commented 3 years ago

Again, if we just mirror the branches we wont lose backwards support, so I'd recommend setting it up how we have our main repo

github-actions[bot] commented 3 years ago

Hi all! This thread has not had any recent activity. Are there any updates? Thanks!

github-actions[bot] commented 2 years ago

Hi everyone. This thread is being closed as there was no response to the previous prompt. However, please leave a comment whenever you're ready to resume, so the thread can be reopened. Thanks again!

marchersimon commented 2 years ago

@CleanMachine1 I think you misunderstood this PR. It just changes from where the client downloads the files and how it names them. For me, the client is still broken and can't update without this change.

CleanMachine1 commented 2 years ago

Then we should probably merge.