search

tldr-pages / tldr-c-client

C command-line client for tldr pages
MIT License
299 stars 49 forks source link

Improve formatting #6

Closed rastersize closed 8 years ago

rastersize commented 8 years ago

This PR aims to improve the formatting of the output so that it works with, more or less, any terminal theme. It should resolve the issues reported in tldr-pages/tldr#388. I’ve tested it with several different themes myself. See the attached screenshots.

It also makes the output be closer to that of the Node.js client, i.e. adding the title to the output and usidn red for the code part. Very similar to the changes in tldr-pages/tldr-node-client#39.

Before

Tomorrow Night theme

screen shot 2015-12-30 at 14 05 55

Solarized Light

screen shot 2015-12-30 at 14 11 48

Light theme (standard in iTerm 2)

screen shot 2015-12-30 at 14 06 46

After

Tomorrow Night theme
screen shot 2015-12-30 at 14 10 55

Solarized Light

screen shot 2015-12-30 at 14 09 31

Light theme (standard in iTerm 2)

screen shot 2015-12-30 at 14 07 59
Leandros commented 8 years ago

Looks good to me! :+1:

johanhaleby commented 8 years ago

:+1: