search

tldr-pages / tldr-node-client

Node.js command-line client for tldr pages 📚
https://www.npmjs.com/package/tldr
MIT License
432 stars 71 forks source link

Plugin not found Command-line Autocompletion #311

Open manaranjoc opened 4 years ago

manaranjoc commented 4 years ago

Expected behaviour

No problems loading the autocompletion plugin with oh-my-zsh.

Actual behaviour

The plugin doesn't load with the instructions given in README.md for oh-my-zsh . I was able to make it work linking the file _tldr located in node_modules/tldr/bin/completion/zsh/_tldr. (is this the correct way?)

output

[oh-my-zsh] plugin 'tldr' not found

Environment

vladimyr commented 3 years ago

I was able to make it work linking the file _tldr located in _node_modules/tldr/bin/completion/zsh/tldr. (is this the correct way?)

Actually, this is not a bug per se - it is more like a case of lacking documentation. You are right, node_modules/tldr/ portion of the path is assummed. :upside_down_face:

bl-ue commented 3 years ago

Needs a PR?

vladimyr commented 3 years ago

If you ask me, needs a better way altogether. The unwritten standard for this kind of thing is to have a completion command with shell name options that outputs the completion code.

bl-ue commented 3 years ago

Then maybe I should drop out of this PR 😄

I'm not good with shell completions 😬😬

vladimyr commented 3 years ago

Well, nobody said picking low hanging fruit in the meantime is a bad thing 😉 You are more than welcome to improve docs 😉