Only download cache for system languages and English

vivekjoshi556 commented 1 year ago

Description

Fixes #419 The task at hand was to update the client so that it would only download the zip files for languages that were supported by the user system. In any case, files in english should be downloaded to act as backup.

Explanation of Solution

While doing this I realized that the unzip library being used was causing issue as it was emitting the close event on extractor twice and because of it the extraction wasn't completing and some of the files were not getting extracted. Trying to resolve it I saw similiar issues on the official repo and the issue wasn't resolved. So I decided to change the npm package to unzip.
It uses both ll & cc to download the correct zip file whenever possible.
Is there a way to determine which languages have different version available (like pt has pt_BR, pt_PT), right now I have hard-coded the values in util.js and it will need to be updated in case other versions for other languages are added.

Checklist

Please review this checklist before submitting a pull request.

[x] Code compiles correctly
[x] Created tests, if possible
[x] All tests passing (npm run test:all)
[ ] Extended the README / documentation, if necessary

agnivade commented 1 year ago

Can we add some tests please?

vivekjoshi556 commented 1 year ago

Can we add some tests please?

@agnivade Sure I'll add the tests Can you please help me with the failing job in the workflow? All the jobs passed when I made the first commit before the PR, but now one of them is failing. It happened in the repo I forked and when I tried to run the job again alone it passed.

All passed again. 🤔

kbdharun commented 1 year ago

Btw, @vivekjoshi556

Workflow requiring approval before running is enabled for first time contributors so that maintainers can review the code before running the action. (This is to minimize multiple failed runs). After this PR is merged, in future the workflow will run by default for you (without requiring approval).

All passed again. 🤔

The reason for it to pass was that I approved your action run an hour ago when you made the comment.

vivekjoshi556 commented 1 year ago

Workflow requiring approval before running is enabled for first time contributors so that maintainers can review the code before running the action. (This is to minimize multiple failed runs). After this PR is merged, in future the workflow will run by default for you (without requiring approval).

I understand they require approval. I was talking about the last time the jobs ran for my changes.
Actions run link. In this run the job for ubuntu-latest, 20.x failed. All others passed.

kbdharun commented 1 year ago

I understand they require approval. I was talking about the last time the jobs ran for my changes. Actions run link. In this run the job for ubuntu-latest, 20.x failed. All others passed.

Oh, it is possible that the action run was cancelled as it reached 6 hours limit (default for action runs in GitHub's runners).

vivekjoshi556 commented 12 months ago

@kbdharun & @agnivade please check this PR & let me know if anything else needs to be updated.

vivekjoshi556 commented 11 months ago

@MasterOdin I am done with the mentioned changes. Please review the PR.

kbdharun commented 11 months ago

I guess this PR can be merged first, then I will rebase mine with this.

tldr-pages / tldr-node-client