tldr-pages / tldr-node-client

Node.js command-line client for tldr pages
https://www.npmjs.com/package/tldr
MIT License
428 stars 70 forks source link

`repository` in the config is not used anymore #438

Open s3i7h opened 3 months ago

s3i7h commented 3 months ago

following up #420

I ended up there while bisecting repositoryrepositoryBase 's silent (and partialy a breaking) change. I believe this PR removed support of setting repository in the configuration file, which makes tldr fallback to default assets instead of the specified one. To handle this:

I think one of the two (prefferably both) of the above measures should be taken. (I think the second one should be implemented with a deprecation warning of some form as it's inefficient for both the client and the server)(if we're going to implement it)

Affected codes between prior to #420 and the current main branch (7ad3c5aa53a40adc3ac419ca682776d20bc828cd..c58c92cd4806840dbe094f28a2a1c47c0f00c67d):

I don't have time currently to make a PR on my own now, so I would appreciate if someone could handle this. However if this remains for a month or two, maybe I can put my hands on it.

agnivade commented 3 months ago

@kbdharun @owenvoke - Wondering if you guys can take a look?