search

tldr-pages / tldr-pages.github.io

🌐 The website for the tldr pages project
http://tldr.sh/
MIT License
76 stars 36 forks source link

added go client to the list. #30

Closed isacikgoz closed 5 years ago

isacikgoz commented 5 years ago

Hi,

Added go client to the clients list. It is the most popular go client.

Thanks in advance.

agnivade commented 5 years ago

@waldyrious - I think we discussed this before. There are currently 3 places which lists clients - this one, the tldr wiki, and the tldr home page. Are we going to update all 3 of them every time we add a new client ?

IMO - we should freeze this list and just add more clients in the home page and wiki.

isacikgoz commented 5 years ago

Thank you for the quick attention. I would be very happy if you freeze after this PR.

If I supposed to add my two cents, This list should contain most active/popular clients IMHO.

p.s. I would like to thank you for all this work.

sbrl commented 5 years ago

How would you suggest measuring client popularity?

isacikgoz commented 5 years ago

@sbrl github stars may give a clue, or gitlab etc

waldyrious commented 5 years ago

@waldyrious - I think we discussed this before. There are currently 3 places which lists clients - this one, the tldr wiki, and the tldr home page. Are we going to update all 3 of them every time we add a new client ?

Funny coincidence, just the other day I started updating the list of clients in the wiki. It now contains all the clients that are listed in the website, so my next step was going to be to submit a PR removing the list from the website and pointing to the wiki. Later I'd propose moving the contents of the wiki to the main repo's README.

So @isacikgoz, if you could, please add this to the wiki page instead, otherwise we'd be merging this change only to revert it in a few days. But if you prefer having this merged anyway, that's fine by me.

As for the popularity measures, that sounds like a good idea. I'll ping you when I open the issue/PR for consolidating the list of clients, where it will be more on-topic to discuss this.

isacikgoz commented 5 years ago

hey @waldyrious , It depends on how quick you move the page :) if it will take some time. I would be happy if you accept the PR!

agnivade commented 5 years ago

@isacikgoz - If your client is on both the wiki and the tldr front pages, then I don't think you have anything to lose. :smile: People generally tend to visit the tldr front page.

waldyrious commented 5 years ago

I guess there's no harm in accepting the PR even if the content is removed soon. The time/effort to propose the PR has already been spent, so I say let's make it worth its while :)