search

tldr-pages / tldr-pages.github.io

🌐 The website for the tldr pages project
http://tldr.sh/
MIT License
76 stars 36 forks source link

Update to use Badges for consistency #34

Closed owenvoke closed 5 years ago

owenvoke commented 5 years ago

This is just an idea, but I feel it looks a little more consistent and ties in with the main repository badges.

Current: current look

Updated: updated look

It also seems a bit odd using an iframe, but maybe it's just me, so feel free to close. 👍

waldyrious commented 5 years ago

@waldyrious any comments ?

Sorry for the delay. I do agree with this change, though. The code is simpler and the visual appearance is more consistent.

I actually would even change the Twitter badge to match the style of the other two, or maybe actually remove it, since the account is not really active anyway. What do you guys think?

agnivade commented 5 years ago

What would the resulting style look like ? Who owns this twitter account anyways ?

waldyrious commented 5 years ago

The current twitter badge is the default style shields.io provides, but we can build a custom badge using an image URL with more parameters. That way the style would be consistent with the other badges.

I'm not sure who the owner of the Twitter account is, but I seem to recall @igorshubovych being one of the people who updated it.

agnivade commented 5 years ago

Ok if somebody wants to do it. It's not a big deal for me.

sbrl commented 5 years ago

I'm not sure we even need access to the twitter account in order to produce a consistent badge.

Example: 

[![](https://img.shields.io/badge/twitter-tldr__pages-%231DA1F2.svg)](https://twitter.com/tldr_pages)
agnivade commented 5 years ago

Oh yea that I know. I was just asking in general. New badge looks good :+1:

waldyrious commented 5 years ago

New badge looks good 👍

Agreed, thanks for putting it together @sbrl! Want to open a PR changing the Twitter badge to this one?

igorshubovych commented 5 years ago

I am the owner of that Twitter account.

I am not doing anything there, so I am open to share it

Sent on the go

On Jun 16, 2019, at 8:41 PM, Waldir Pimenta notifications@github.com wrote:

New badge looks good 👍

Agreed, thanks for putting it together @sbrl! Want to open a PR changing the Twitter badge to this one?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

sbrl commented 5 years ago

Sure! I'll open a PR.